Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: speed up mac build times in CI #20473

Merged
merged 4 commits into from
Mar 4, 2022
Merged

Conversation

emilyrohrbough
Copy link
Member

Screen Shot 2022-03-03 at 4 00 01 PM

Updated and pushed to see build times were faster. Seems like they might just be!

Reference Build Times - Looked at jobs without installing node_modules
Screen Shot 2022-03-03 at 4 02 30 PM

Updated Build Times - Neither build installed node_modules

Screen Shot 2022-03-03 at 4 01 47 PM

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 3, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Mar 3, 2022



Test summary

19278 0 218 0Flakiness 0


Run details

Project cypress
Status Passed
Commit 98e71af
Started Mar 4, 2022 5:04 PM
Ended Mar 4, 2022 5:16 PM
Duration 11:52 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@flotwig flotwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I'll take it.

I feel like it's kind of hard to figure out just how much this improves things, because the notarization step seems to take an indeterminate amount of time to complete. But it does definitely seem to be an improvement.

@JessicaSachs I know you were looking in to why the notarization step takes so long recently, were you able to find anything?

@ryanthemanuel ryanthemanuel self-requested a review March 4, 2022 16:47
@emilyrohrbough emilyrohrbough merged commit 469dfe4 into develop Mar 4, 2022
@emilyrohrbough emilyrohrbough deleted the faster-mac-builds branch March 4, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants