Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document patch-package best practices #20511

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Mar 7, 2022

User facing changelog

n/a

Additional details

  • Documents best practices around using patch-package in the Cypress monorepo.

How has the user experience changed?

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 7, 2022

Thanks for taking the time to open a PR!

@flotwig flotwig force-pushed the issue-20400-document-patch-package branch from e456d72 to 938f72a Compare March 7, 2022 16:11
@flotwig flotwig marked this pull request as ready for review March 7, 2022 16:22
@cypress
Copy link

cypress bot commented Mar 7, 2022



Test summary

19278 0 218 0Flakiness 1


Run details

Project cypress
Status Passed
Commit 938f72a
Started Mar 9, 2022 4:17 PM
Ended Mar 9, 2022 4:29 PM
Duration 11:44 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/cypress/proxy-logging_spec.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for documenting. @flotwig Can you ping the team in Slack to inform them of the new doc once this is merged?

@flotwig flotwig merged commit 2d81628 into develop Mar 8, 2022
@flotwig flotwig deleted the issue-20400-document-patch-package branch March 8, 2022 02:32
@cypress-bot cypress-bot bot mentioned this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document patch-package
3 participants