Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove parallelism from test-binary-against-repo jobs #21004

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

tgriesser
Copy link
Member

User facing changelog

N/A

Additional details

Removes parallelism from a few jobs against remote repose that aren't benefitting from it

How has the user experience changed?

PR Tasks

  • N/A Have tests been added/updated?
  • N/A Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • N/A Has a PR for user-facing changes been opened in cypress-documentation?
  • N/A Have API changes been updated in the type definitions?
  • N/A Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 8, 2022

Thanks for taking the time to open a PR!

@tgriesser tgriesser requested a review from flotwig April 8, 2022 18:12
Copy link
Contributor

@flotwig flotwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it non-trivial to parallelize these frfr? they take forever

@cypress
Copy link

cypress bot commented Apr 8, 2022



Test summary

19391 0 218 0Flakiness 3


Run details

Project cypress
Status Passed
Commit f181592
Started Apr 8, 2022 6:16 PM
Ended Apr 8, 2022 6:28 PM
Duration 12:28 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/net_stubbing_spec.ts Flakiness
1 network stubbing > waiting and aliasing > should handle aborted requests
cypress/proxy-logging_spec.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second
2 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jennifer-shehane jennifer-shehane changed the title fix: remove parallelism from test-binary-against-repo jobs chore: remove parallelism from test-binary-against-repo jobs Apr 8, 2022
@jennifer-shehane jennifer-shehane merged commit 933e0eb into develop Apr 8, 2022
@jennifer-shehane jennifer-shehane deleted the tgriesser/fix/remove-parallelism branch April 8, 2022 18:42
@tgriesser
Copy link
Member Author

is it non-trivial to parallelize these frfr? they take forever

Idk, didn't look into it. We probably should use something like the cypress dashboard to run them 😛

@flotwig
Copy link
Contributor

flotwig commented Apr 8, 2022

recipes contains a ton of projects, so the dashboard can't really help here. But I'm sure something could be done with circleci's test splitting, if the cypress-example-recipes repo doesn't have anything for it yet.

tgriesser added a commit that referenced this pull request Apr 14, 2022
* 10.0-release: (25 commits)
  fix: stop running spec when switching specs (#21038)
  fix: remove asset size warnings and enable nuxt e2e tests (#21074)
  feat: swap the #__cy_root id selector to become data-cy-root for component mounting (#20951)
  fix: Doc changes around vue2 (#21066)
  feat: Add vue2 package from npm/vue/v2 branch (#21026)
  skip failing test
  fix: add possible frameworks to object API config (#21056)
  fix snapshot spacing
  fix system test
  fix snapshot
  update snapshots
  rename spec files
  rename files
  update snapshots
  release 9.5.4 [skip ci]
  fix(regression): cy.pause() should not be ignored with `cypress run --headed --no-exit` (#20877)
  fix: add missing Cypress.Commands.addAll() types (#20894)
  chore: Don't store video and screenshot artifacts for runs (#20979)
  chore: Update Chrome (beta) to 101.0.4951.26 (#20957)
  chore: remove parallelism from test-binary-against-repo jobs (#21004)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants