-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: develop (including cy.origin) merge into 10.0 #21237
Changes from 1 commit
66d947d
700636a
b36fdff
51dea49
4288ce6
53cd6d1
548db6e
31e6d3f
617f321
a3930c2
4323215
f5d326a
3ad6c36
fef49f4
16ad6b4
4e140a2
92932c5
cc66129
416aabe
2aea225
fb5ff06
9503b40
8f11635
516100b
c6d2918
2c28961
8ac1ff0
0eeb442
10264e6
b5a135d
37b881e
cd77e08
dacf0a5
f716178
f2c6069
ee6e105
a42e601
a408b36
2ee9893
8e0770f
cc08d12
2e5fbad
d8fa85d
0601570
0b39332
d3601f6
7ef104e
c84ace4
1faed02
89a497f
3295adf
2475b5a
1d69100
fdb0c96
b50fe56
bab8496
fe03453
4070270
c58a0ee
dc9b694
c198372
92bf23c
0639d14
191dc92
8d54632
89ea47d
b6e1c30
5f905ee
5269f4f
288f6bd
5b4feaa
0e942ed
fc7149e
b6243f5
c8c2046
a0c6f00
4c36cf9
ae65ae6
1eb5ab7
74dea89
ca1857f
ca510ce
cd7f99d
892d8d9
d1c3e4e
46c0c75
7f3a649
bc30c68
326fc19
9cc3108
0e8c511
193a01a
35501bc
ebb054e
432b3d5
f0a90e1
e4f78a0
44161a9
86ade70
9827b26
f638ba7
89c0091
22b35be
a64cdb8
c7aa180
90d1eb7
ad176be
3c19edb
8f7cc74
14215e3
453d1ca
fedb65c
04eabf0
3b4b0ef
4c1c18d
b77f675
9098744
1fa78f5
8c9bd2a
b3e66e7
8bba681
0c78630
15a60c1
f45be5e
81e9283
0772f85
17e6bf4
213607f
b65db7b
dcbc68b
25af921
c686922
8a78b5c
782d89f
63c3247
a7caf8a
f6975f8
a928781
fdfa933
8959845
836edbf
65d75dd
f451d05
d98d0e1
663e5d5
dd3557f
27e1afb
c560caf
e4dcb12
890bde6
f02d750
afca88e
86f5b49
68173be
d7ce865
81f8a85
55e7f8a
e3161a0
f819be3
342bc06
f164404
885541e
0bb655e
a1101e6
ebaaf18
3e6d6bf
d866746
b8ae51e
f473d29
676fc97
2d866f3
2338635
3d7ab6a
4972872
30a9a27
363c1a8
2709b69
fbaaeb7
f9ad6a8
6b3e79d
7fa946d
b625994
bc01e44
51b4bdc
fe3e2af
233cb47
a47b45f
bbd9e7f
7e79860
0a0d709
a31e19a
373ed05
7a76de1
217f4c5
252566c
328a826
bd7d228
d782cfc
f6e8bc5
e8b6e8c
4f9dc00
a68fb4b
3aa74f4
fd3c9ba
038c225
1950b93
0d48543
37830ad
673a238
b8c6ad7
53653bd
5f8070c
3fb0847
899290d
577edc6
c8331fc
32809eb
d61026f
b5b281d
2ffae65
2830c9e
399ee7b
61bd6c8
5a071bb
a0ddcf8
65eea21
de1a3bd
aed753a
f0259ee
3f8cd51
bd7e43e
0f1e06f
b0f3f11
b57e2a8
df226a5
1d76152
4a2bee3
04dc2e3
4fe7b3f
b66d35a
a374f3c
d9aa8ee
3715d3e
56ee2a5
2595c44
0fd58d6
bd428a5
295cd02
cd8ad4c
1618a99
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -324,7 +324,7 @@ const onReconnect = (client: CRIWrapper.Client) => { | |
// if the client disconnects (e.g. due to a computer sleeping), update | ||
// the frame tree on reconnect in cases there were changes while | ||
// the client was disconnected | ||
_updateFrameTree(client)() | ||
return _updateFrameTree(client)() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this asynchronous? Do we need to await it in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it is asynchronous, but we do not need to await it. The |
||
} | ||
|
||
// eslint-disable-next-line @cypress/dev/arrow-body-multiline-braces | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type here was originally removed, but then decorated. A
TODO
item here likely needs to be to migrate this type to theinternal-types.d.ts
file to satisfy this conversationThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe the
internal-types-lite.d.ts
that was recently added?