-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow submit button to be outside of the form for implicit submission #21279
fix: Allow submit button to be outside of the form for implicit submission #21279
Conversation
Thanks for taking the time to open a PR!
|
@skvale Thanks for the contribution and for adding tests around the new behavior. Could you please sign our CLA? After that we’ll have someone from our team review as soon as possible. |
Co-authored-by: Zach Bloomquist <github@chary.us>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see this :)
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
Submit buttons can be outside of the form for implicit submission
Additional details
Implicit submit wasn't working when the submit button wasn't nested within the form
How has the user experience changed?
Implicit submit with the enter key works when the submit button is outside of the form, but associated with a form attribute
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?