fix: scroll of inline specs list #21994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
There was a problem hiding this comment.
@marktnoonan Any way to add a Cypress test to actually scroll and check this? That would be a better test than relying on this specific style. Use scroll commands within Cypress?
|
Test summary
Run details
View run in Cypress Dashboard ➡️ FlakinessThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
flotwig
approved these changes
Jun 1, 2022
mjhenkes
approved these changes
Jun 1, 2022
ZachJW34
approved these changes
Jun 1, 2022
tgriesser
added a commit
that referenced
this pull request
Jun 1, 2022
…ss-io/cypress into tgriesser/fix/21997-fix-invalid-ts * 'tgriesser/fix/21997-fix-invalid-ts' of github.com:cypress-io/cypress: fix: scroll of inline specs list (#21994)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
In the Runner page, the inline specs list will now scroll as expected.
Additional details
The overflow styles were changed incorrectly in this PR last week. Removing the
overflow-hiddenclass restores the correct behavior of the specs list. The!importantof the tailwind class clobbered the overflow that theuseVirtualListsets on the wrapper of the virtual list.Steps to test
Visit a spec and confirm that the inline specs list is scrollable vertically.
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?