Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add padding to bottom of global mode list #22112

Merged
merged 15 commits into from
Jun 30, 2022
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/launchpad/cypress/e2e/global-mode.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ describe('Launchpad: Global Mode', () => {
expect(card).to.contain(projectList[index])
expect(card).to.contain(`cy-projects${sep}${projectList[index]}`)
})

cy.percySnapshot()
}

it('shows the recent projects list sorted by most-recently opened', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/launchpad/src/Main.vue
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
/>
<div
v-else
class="px-24px pt-86px"
class="px-24px pt-86px pb-24px"
>
<BaseError
v-if="query.data.value.baseError"
Expand Down
4 changes: 3 additions & 1 deletion packages/launchpad/src/global/GlobalPage.vue
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
>
{{ t('globalPage.recentProjectsHeader') }}
</h2>
<div :class="{ 'md:grid md:grid-cols-2 md:gap-24px mb-0': filteredProjects?.length > 1 }">
<div
:class="{ 'md:grid md:grid-cols-2 md:gap-24px mb-0': filteredProjects?.length > 1 }"
>
<GlobalProjectCard
v-for="project in filteredProjects"
:key="project.id"
Expand Down