Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SpecsList scrolling performance fixes #22256

Merged
merged 5 commits into from
Jun 11, 2022
Merged

fix: SpecsList scrolling performance fixes #22256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8bbe8aa
fix: SpecsList scrolling performance fixes
mike-plummer Jun 10, 2022
1cf0e3f
fix: Attempt to fix tooltip disposal issue
mike-plummer Jun 10, 2022
0a23a61
fix: ACI styling issues
mike-plummer Jun 10, 2022
54a08ad
fix: Tooltip hide issue
mike-plummer Jun 10, 2022
3c33a6b
fix: Fix cursor styling on tooltip headers
mike-plummer Jun 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/app/src/specs/LastUpdatedHeader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
:is-interactive="true"
>
<div
class="decoration-dotted underline underline-gray-300 underline-offset-4"
class="cursor-default decoration-dotted underline underline-gray-300 underline-offset-4"
tabindex="0"
data-cy="last-updated-header"
>
Expand Down
2 changes: 2 additions & 0 deletions packages/app/src/specs/RunStatusDots.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
placement="top"
:is-interactive="true"
class="h-16px"
:hide-delay="0"
:show-group="props.gql.id"
popper-class="RunStatusDots_Tooltip"
>
<component
Expand Down
2 changes: 1 addition & 1 deletion packages/app/src/specs/SpecHeaderCloudDataTooltip.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
:is-interactive="true"
>
<div
class="decoration-dotted underline underline-gray-300 underline-offset-4"
class="cursor-default decoration-dotted underline underline-gray-300 underline-offset-4"
tabindex="0"
>
{{ headerText }}
Expand Down
4 changes: 2 additions & 2 deletions packages/app/src/specs/SpecsList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,9 +392,9 @@ useResizeObserver(containerProps.ref, (entries) => {
}
})

// If you are scrolled down the virtual list and list changes,
// If you are scrolled down the virtual list and the search filter changes,
// reset scroll position to top of list
watch(() => treeSpecList.value, () => scrollTo(0))
watch(() => debouncedSearchString.value, () => scrollTo(0))

function getIdIfDirectory (row) {
if (row.data.isLeaf && row.data) {
Expand Down
9 changes: 8 additions & 1 deletion packages/frontend-shared/src/components/Tooltip.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
:distance="distance"
:skidding="skidding"
:auto-hide="false /* to prevent the popper from getting focus */"
:delay="{show: 0, hide: 100 }"
:delay="{show: 0, hide: hideDelay }"
:show-group="showGroup"
>
<slot />
<template
Expand All @@ -35,6 +36,9 @@ const props = withDefaults(defineProps<{
skidding?: number
placement?: 'top' | 'right' | 'bottom' | 'left'
popperClass?: string
hideDelay?: number
instantMove?: boolean
showGroup?: string
}>(), {
color: 'dark',
hideArrow: false,
Expand All @@ -44,6 +48,9 @@ const props = withDefaults(defineProps<{
skidding: undefined,
placement: undefined,
popperClass: undefined,
hideDelay: 100,
instantMove: undefined,
showGroup: undefined,
})

const theme = computed(() => {
Expand Down