Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add baseUrl to TestConfigOverrides #22532

Closed

Conversation

imadx
Copy link
Contributor

@imadx imadx commented Jun 27, 2022

User-facing changelog

Corrected the Typescript types to include baseUrl as a valid test config override option. Fixes #22374 and #22072.

Additional details

The documentation mentions that baseUrl is also configurable and can be changed at run time.
https://docs.cypress.io/guides/references/configuration#Test-Configuration

However, the types are missing baseUrl there for TestConfigOverrides.

Steps to test

Updating baseUrl in a test with Cypress.config("baseUrl", baseUrl); can be used to test the behaviour.

How has the user experience changed?

Before

image

After

There is no typescript warning

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 27, 2022

Thanks for taking the time to open a PR!

@imadx imadx closed this Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant