fix: add context for run-new-ui-tests dependent jobs #22561
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
n/a
Additional details
With #22326 merged in, internal PRs were no longer recording to the dashboard since the jobs didn't have the
test-runner:cypress-record-key
context and thus didn't haveMAIN_RECORD_KEY
available.I thought about changing the
MAIN_RECORD_KEY
toTEST_LAUNCHPAD_RECORD_KEY
but there is a fallback toMAIN_RECORD_KEY
in the script so I settled on adding the additional context.Steps to test
Look at a PR from an internal contributor after #22326 was merged, example:
notice the use of
--spec
which should only be used for external contributor test splitting.A build from this PR looks like:
This build is now using the
--record
flag as intendedHow has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?