-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add login state to manifest request for analytics #22791
feat: Add login state to manifest request for analytics #22791
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
N/A
Additional details
x-logged-in
header on check for updates manifest request for Product analyticsSteps to test
Unfortunately, request headers aren't logged in our debug calls so there isn't an easy way to validate this as-is. As a workaround you can add
console.log(manifestHeaders)
somewhere around here inVersionsDataSource
and follow this procedure:x-logged-in
header is accurate for your login stateHow has the user experience changed?
No visible change
PR Tasks
cypress-documentation
?type definitions
?