Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add login state to manifest request for analytics #22791

Merged
merged 5 commits into from
Jul 19, 2022

Conversation

mike-plummer
Copy link
Contributor

@mike-plummer mike-plummer commented Jul 14, 2022

User facing changelog

N/A

Additional details

  • Pass new x-logged-in header on check for updates manifest request for Product analytics

Steps to test

Unfortunately, request headers aren't logged in our debug calls so there isn't an easy way to validate this as-is. As a workaround you can add console.log(manifestHeaders) somewhere around here in VersionsDataSource and follow this procedure:

  1. Open the app, launchpad should appear
  2. Check whether you are logged in within the app
  3. Check your console log, the manifest headers should have output and you can confirm the value of the x-logged-in header is accurate for your login state
  4. If logged in, logout or vice versa and repeat to confirm the header reflects correctly for both states

How has the user experience changed?

No visible change

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 14, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jul 14, 2022



Test summary

37729 0 456 0Flakiness 10


Run details

Project cypress
Status Passed
Commit dfb7416
Started Jul 19, 2022 3:27 PM
Ended Jul 19, 2022 3:45 PM
Duration 17:22 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/commands/xhr.cy.js Flakiness
1 ... > logs request + response headers
2 ... > logs Method, Status, URL, and XHR
3 ... > logs response
4 ... > logs request + response headers
5 ... > logs Method, Status, URL, and XHR
This comment includes only the first 5 flaky tests. See all 10 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mike-plummer mike-plummer requested review from ZachJW34, flotwig and a team and removed request for a team July 16, 2022 00:54
@mike-plummer mike-plummer marked this pull request as ready for review July 16, 2022 00:59
@mike-plummer mike-plummer requested review from a team as code owners July 16, 2022 00:59
@mike-plummer mike-plummer removed request for a team July 16, 2022 00:59
@mike-plummer mike-plummer merged commit 36278fc into develop Jul 19, 2022
@mike-plummer mike-plummer deleted the 22754-add-login-state-to-manifest-request branch July 19, 2022 22:17
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 2, 2022

Released in 10.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.4.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add loggedIn property to Check for Updates call
3 participants