Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spike: Cypress Studio #23181

Closed
wants to merge 8 commits into from
Closed

spike: Cypress Studio #23181

wants to merge 8 commits into from

Conversation

lmiller1990
Copy link
Contributor

@lmiller1990 lmiller1990 commented Aug 8, 2022

Note: nothing to review w.r.t code here - main info is in this description and this slack channel (Cypress team only).

User facing changelog

N/A

Additional details


I looked into hooking up Cypress Studio in Cypress 10. Most of the code and infrastructure is still there, so it's a matter of wiring it all up. I think to get it working the correct fashion with all the requisite error handling, it's an additional ~30 hours of effort.

Video demo of basic funtionality working (had to hard code some variables and did not implement full UI): https://user-images.githubusercontent.com/19196536/183324807-41237d67-ee96-468b-be19-5f88098488be.mp4.

In addition, we need to have a UI that matches with the existing design system. The main thing we don't have is a kind of overlay with focused tooltip for "enter a URL".

Here is a list of all the Studio UI elements - I'm not sure if we need to update them to be in line with our new design system, or we are happy to push this out under as-is under the experimental flag.

Studio URL Overlay

image

Studio Controls

image

Studio Modal

image

Steps to test

It's not meant to be tested - this is just a spike branch.

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 8, 2022

Thanks for taking the time to open a PR!

@@ -19,7 +19,6 @@ export type BreakingOptionErrorKey =
| 'EXPERIMENTAL_RUN_EVENTS_REMOVED'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File above this (hidden by GitHub by default) is the store, ported to Pinia.

@lmiller1990
Copy link
Contributor Author

@cypress
Copy link

cypress bot commented Aug 8, 2022



Test summary

37832 0 615 0Flakiness 7


Run details

Project cypress
Status Passed
Commit 87fb624
Started Aug 17, 2022 5:53 AM
Ended Aug 17, 2022 6:08 AM
Duration 15:00 💡
OS Linux Debian - 11.3
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/commands/net_stubbing.cy.ts Flakiness
1 network stubbing > intercepting request > can delay with deprecated delayMs param
2 network stubbing > intercepting request > can delay with deprecated delayMs param
3 network stubbing > intercepting request > can delay with deprecated delayMs param
4 network stubbing > intercepting request > can delay with deprecated delayMs param
5 network stubbing > intercepting request > can delay with deprecated delayMs param
This comment includes only the first 5 flaky tests. See all 7 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990
Copy link
Contributor Author

In favor of #23413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress Studio Reimplementation Spike
1 participant