-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spike: Cypress Studio #23181
spike: Cypress Studio #23181
Conversation
Thanks for taking the time to open a PR!
|
packages/config/src/options.ts
Outdated
@@ -19,7 +19,6 @@ export type BreakingOptionErrorKey = | |||
| 'EXPERIMENTAL_RUN_EVENTS_REMOVED' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File above this (hidden by GitHub by default) is the store, ported to Pinia.
Test summaryRun details
View run in Cypress Dashboard ➡️ FlakinessThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
In favor of #23413 |
Note: nothing to review w.r.t code here - main info is in this description and this slack channel (Cypress team only).
User facing changelog
N/A
Additional details
I looked into hooking up Cypress Studio in Cypress 10. Most of the code and infrastructure is still there, so it's a matter of wiring it all up. I think to get it working the correct fashion with all the requisite error handling, it's an additional ~30 hours of effort.
Video demo of basic funtionality working (had to hard code some variables and did not implement full UI): https://user-images.githubusercontent.com/19196536/183324807-41237d67-ee96-468b-be19-5f88098488be.mp4.
In addition, we need to have a UI that matches with the existing design system. The main thing we don't have is a kind of overlay with focused tooltip for "enter a URL".
Here is a list of all the Studio UI elements - I'm not sure if we need to update them to be in line with our new design system, or we are happy to push this out under as-is under the experimental flag.
Studio URL Overlay
Studio Controls
Studio Modal
Steps to test
It's not meant to be tested - this is just a spike branch.
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?