fix: writeFile returns string instead JSON #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If input of writeFile is an object, it should return an object after successful write instead of a string.
|
|
|
Thanks for submitting this. Could you please add a test? https://github.com/cypress-io/cypress/blob/develop/packages/driver/test/cypress/integration/commands/files_spec.coffee#L246 |
|
I just forgot that, added. |
|
Thanks for the test. There's an issue with Circle CI related to PRs from forks and the cache that's causing all the tests to fail. Once we resolve that and see all the tests pass, we'll get this merged. |
|
the failure is due to group run bug, will be fixed soon by pushing the API |
|
@lilaconlee per our discussion today... forgot this was an open PR, hah |
brian-mann
added
the
type: unexpected behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to docs, if input of writeFile is an object, it should return an object after successful write instead of a string.
This issue was mentioned here : While writing to a file and then asserting a Cypress.io test, the system throws 'expected undefined to equal..'