Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update mocha-junit-reporter in server package #24218

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

Turbotailz
Copy link
Contributor

@Turbotailz Turbotailz commented Oct 12, 2022

This change was meant to be included in #24056 but I missed the dependency also residing in the server package.json

This should fix #18970

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 12, 2022

Thanks for taking the time to open a PR!

Copy link
Contributor

@marktnoonan marktnoonan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not actually requesting changes, but since we have folks on the issue willing to try out a pre-release version, let's get that validation done before we merge, to make sure there's nothing else needed to close that issue.

@AtofStryker AtofStryker merged commit 96dfa0c into cypress-io:develop Oct 13, 2022
@Turbotailz Turbotailz deleted the fix/mocha-junit-reporter branch October 13, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"TypeError: testcase.testcase[0]._attr.time.toFixed is not a function" error happens often in CI pipeline
4 participants