Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restart server on blockHost configuration change #24257

Merged
merged 2 commits into from
Oct 14, 2022
Merged

fix: Restart server on blockHost configuration change #24257

merged 2 commits into from
Oct 14, 2022

Conversation

meisster
Copy link
Contributor

@meisster meisster commented Oct 14, 2022

User facing changelog

Cypress will now restart on changes to blockHosts configuration entry. Fixes #22634

Additional details

Changes to blockHosts configuration entry should trigger a restart and result in new values being properly loaded.

Steps to test

Launch cypress, modify blockHosts entry, wait for cypress to restart and see if new values are used.

How has the user experience changed?

Can now change blockHosts entry without the need to manually rerun cypress.

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 14, 2022

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Oct 14, 2022

CLA assistant check
All committers have signed the CLA.

@meisster meisster changed the title Restart server on blockHost configuration change fix: Restart server on blockHost configuration change Oct 14, 2022
@meisster meisster marked this pull request as ready for review October 14, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes to blockHosts config value should trigger restart
4 participants