fix: get correct env from npm config #24664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
|
ryanthemanuel
requested changes
Nov 17, 2022
I don't know how to add this test case. Because If we add this command in unit test, then we should execute this test in sub process. |
abcfy2
force-pushed
the
develop
branch
2 times, most recently
from
32ecdb1
to
761cfec
Compare
I try to add a simple unit test for this. You can review again. Thanks. |
ryanthemanuel
approved these changes
Nov 22, 2022
mjhenkes
approved these changes
Nov 23, 2022
abcfy2
force-pushed
the
develop
branch
2 times, most recently
from
248a3b9
to
5d33f30
Compare
`npm config set VAR VAL` will inject `npm_config_var=val` environment variable. This commit will solve this issue Closes: cypress-io#24556
|
Hi @marktnoonan . Please review my PR and let me know if I lost something. Thanks. |
mjhenkes
reviewed
Nov 29, 2022
mjhenkes
reviewed
Nov 29, 2022
mjhenkes
reviewed
Nov 29, 2022
mjhenkes
reviewed
Nov 29, 2022
mjhenkes
reviewed
Nov 29, 2022
mjhenkes
reviewed
Nov 29, 2022
|
Yay a green build, @abcfy2 thanks for the PR and being patient while i got the build fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm config set VAR VALwill injectnpm_config_var=valenvironment variable. This commit will solve this issueCloses: #24556