Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add eslint config to system-test project fixtures #25089

Merged
merged 5 commits into from
Dec 9, 2022

Conversation

chrisbreiding
Copy link
Contributor

@chrisbreiding chrisbreiding commented Dec 9, 2022

User facing changelog

N/A

Additional details

Linting was failing on system tests project fixture specs if you changed one of them since Cypress globals weren't configured. The main change is adding an .eslintrc.json to the project-fixtures directory. The rest of the changes are eslint auto-fixes.

Steps to test

How has the user experience changed?

PR Tasks

  • [N/A] Have tests been added/updated?
  • [N/A] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [N/A] Has a PR for user-facing changes been opened in cypress-documentation?
  • [N/A] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 9, 2022

Thanks for taking the time to open a PR!

@chrisbreiding chrisbreiding changed the title chore: Add eslint config to system-test project fixtures [run ci] chore: Add eslint config to system-test project fixtures Dec 9, 2022
@cypress
Copy link

cypress bot commented Dec 9, 2022



Test summary

25006 0 2489 0Flakiness 25


Run details

Project cypress
Status Passed
Commit c862d66
Started Dec 9, 2022 7:35 PM
Ended Dec 9, 2022 7:52 PM
Duration 16:58 💡
OS Linux Debian -
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/e2e/origin/cookie_behavior.cy.ts Flakiness
1 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
2 ... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
3 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
4 ... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
5 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
This comment includes only the first 5 flaky tests. See all 25 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@chrisbreiding chrisbreiding merged commit 4cb1c07 into develop Dec 9, 2022
@chrisbreiding chrisbreiding deleted the crb/system-test-fixtures-eslint-fix branch December 9, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants