Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up config for external contibutors #25552

Merged
merged 6 commits into from
Jan 30, 2023
Merged

Conversation

emilyrohrbough
Copy link
Member

@emilyrohrbough emilyrohrbough commented Jan 24, 2023

When creating the limited CI runs in Circle, I wrote it to cancel the workflow to make it understood the full workflow did not run. Circle does not provide a first-class way to cancel the pipeline, so I leveraged their API to cancel it. However to do so, a CIRCLE_TOKEN was required to authenticate.

This process worked fine for cypress members, but resulted in Unathorized CircleCI kickoff. (example)
Screen Shot 2023-01-24 at 10 01 23 AM

It appears @estrada9166 is not apart of the Cypress App github team, and was experiencing this issue. He applied this change here: 8581950 (#25237)
And the job was successfully kicked off: https://app.circleci.com/pipelines/github/cypress-io/cypress/48589

Closes #25553

@emilyrohrbough emilyrohrbough marked this pull request as ready for review January 24, 2023 16:04
@cypress
Copy link

cypress bot commented Jan 24, 2023

42 flaky tests on run #43565 ↗︎

0 26600 1274 0 Flakiness 42

Details:

Merge branch 'develop' into emily/ci-change
Project: cypress Commit: 80cade9780
Status: Passed Duration: 19:58 💡
Started: Jan 30, 2023 2:28 PM Ended: Jan 30, 2023 2:48 PM
Flakiness  e2e/origin/cookie_behavior.cy.ts • 4 flaky tests • 5x-driver-electron

View Output Video

Test
... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
Flakiness  e2e/origin/commands/navigation.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test
cy.origin navigation > #consoleProps > .go()
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test
network stubbing > intercepting request > can delay and throttle a StaticResponse
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test
... > correctly returns currentRetry
... > correctly returns currentRetry
... > correctly returns currentRetry
Flakiness  e2e/origin/commands/waiting.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test
cy.origin waiting > alias > waits for the route alias to have a response

The first 5 flaky specs are shown, see all 21 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@emilyrohrbough
Copy link
Member Author

Full disclosure. After helping @estrada9166 some more, I think we have also tightened our restrictions around our context sharing and env passing in CircleCI where this will allow CircleCI to kick-off but anywhere were contexts/envs are referenced, contributes who are not apart of the App Team will received "Unauthorized".

@emilyrohrbough emilyrohrbough merged commit 86f92da into develop Jan 30, 2023
@emilyrohrbough emilyrohrbough deleted the emily/ci-change branch January 30, 2023 15:32
tgriesser added a commit that referenced this pull request Jan 31, 2023
* develop:
  chore: fix changlelog section parsing and reference right ENV (#25633)
  feat: Debug page [IATR] (#25488)
  fix(deps): update dependency underscore.string to v3.3.6 🌟 (#25574)
  chore: Use upstream cypress-testing-library again (#25548)
  fix: match alternate edge version string format (#25457)
  chore: update name for graphql batch operations (#25610)
  chore: clean up config for external contibutors (#25552)
  chore: fix childProcess.execSync encoding (#25625)
  chore: update next-version to handle using the next bump package.json… (#25599)
  chore: update packages/example deployment script and cleanup package/example (#25091)
  fix: allow version 9 of the babel-loader peer dependency (#25569)
  docs: remove cypress-example-todomvc-redux from release-process (#25613)
  chore: bump version and remove misleading changelog entry (#25612)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up CircleCI Setup & Triggers
4 participants