Truncate file names for screenshots #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilaconlee
force-pushed
the
issue-2403-truncate-screenshot-name
branch
from
f564b26 to
7b1f765
Compare
lilaconlee
commented
Oct 31, 2018
| @@ -313,14 +314,24 @@ getPath = (data, ext, screenshotsFolder) -> | |||
| else | |||
| names = [data.titles.map(replaceInvalidChars).join(RUNNABLE_SEPARATOR)] | |||
|
|
|||
| # truncate file names to be less than 220 characters | |||
| # to accomodate filename size limits | |||
| maxFileNameLength = 220 | |||
There was a problem hiding this comment.
This is a bit funky. From testing outside of Cypress, seems like this value should be 255 - length of (failed) (N).png, but that still causes a name too long error on CI. That doesn't happen when this value is a bit smaller 🤷♀️
|
I think ideally we would not truncate ahead of time, but instead recover from thrown errors like I'm merging this in regardless, but in case we wanted to tighten up later we could. |
This was referenced Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opted to set a max length of 242 for the original string so it's 255 with
(failed).png