fix: yield waited responses in the order that they occured

[astone123]

• Closes cy.wait on an array of the same alias does not resolve in expected order #27337

Additional details

This PR sorts the yielded responses from a cy.wait command by browserRequestId so that the responses are returned in the correct order even when the same alias name is used.

Steps to test

Follow the reproduction steps in the original issue

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?

[cypress]

9 flaky tests on run #51416 ↗︎

0

9872

1078

0

9

Details:

collate new tests under existing describe
Project: cypress	Commit: 06ab7c0387
Status: Passed	Duration: 17:31 💡
Started: Oct 3, 2023 7:36 PM	Ended: Oct 3, 2023 7:54 PM

  e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test		Artifacts
cy.origin assertions > #consoleProps > .should() and .and()		Output

  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox

View Output Video

Test		Artifacts
... > correctly returns currentRetry		Output
... > correctly returns currentRetry		Output
... > correctly returns currentRetry		Output

  commands/net_stubbing.cy.ts • 2 flaky tests • 5x-driver-webkit

View Output Video

Test		Artifacts
... > with `times` > only uses each handler N times		Output
... > stops waiting when an xhr request is canceled		Output

  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-webkit

View Output Video

Test		Artifacts
... > correctly returns currentRetry		Output
... > correctly returns currentRetry		Output
... > correctly returns currentRetry		Output

Review all test suite changes for PR #27806 ↗︎

[chrisbreiding]

We should add a test for this.

[dkasper-was-taken]

We should add a test for this.

@chrisbreiding Test case added.

[chrisbreiding]

Over all looks good, though the new test seems to be failing or flaky in webkit 😔

[dkasper-was-taken]

Over all looks good, though the new test seems to be failing or flaky in webkit 😔

@chrisbreiding Looking at webkit, it fails locally as well. Apparently if we wait 6 or more aliases the call fails to resolve regardless of timeout set. This occurs even if I revert the newly added sort logic.

Are there any known limitations with webkit around the # of xhr calls?

[chrisbreiding]

Are there any known limitations with webkit around the # of xhr calls?

Not that I know of, but webkit has a lot of known and unknown issues, so it's not too surprising there's a weird issue with it.

[chrisbreiding]

I guess we should just have the test use less aliases so that it can work in webkit too.

involved in change

[cypress-bot]

Released in 13.3.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.3.1, please open a new issue.