Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade commit info dependency to fall back on environment variables to get Git commit #2895

Merged
merged 8 commits into from
Dec 17, 2018
Merged

Upgrade commit info dependency to fall back on environment variables to get Git commit #2895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
aae6658
chore: upgrade commit-info to 2.1.1 in server, close #2848
bahmutov Dec 4, 2018
c57f428
chore: using mocked-env to test CI params
bahmutov Dec 4, 2018
ac7f08d
update more CI env tests
bahmutov Dec 4, 2018
dbe7132
update last CI tests to use mocked-env
bahmutov Dec 4, 2018
2e2ef62
test git commit info from environment variables
bahmutov Dec 4, 2018
a73127c
do not crash on undefined when running npm t
bahmutov Dec 4, 2018
71961ef
remove duplicate object key to pass linter
bahmutov Dec 4, 2018
7f6e038
Merge branch 'develop' into upgrade-commit-info-2848
bahmutov Dec 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@
"https-proxy-agent": "^1.0.0",
"inquirer": "3.0.6",
"istanbul": "^0.4.2",
"mocked-env": "1.2.4",
"mockery": "^1.4.0",
"nock": "9.0.22",
"nodemon": "^1.8.7",
Expand All @@ -97,7 +98,7 @@
},
"dependencies": {
"@cypress/browserify-preprocessor": "1.1.2",
"@cypress/commit-info": "2.0.0",
"@cypress/commit-info": "2.1.1",
"@cypress/icons": "0.5.4",
"@cypress/mocha-teamcity-reporter": "^1.0.0",
"@ffmpeg-installer/ffmpeg": "1.0.15",
Expand Down
2 changes: 1 addition & 1 deletion packages/server/test/scripts/run.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const options = minimist(process.argv.slice(2))

let run = options._[0]

if (run.includes('--inspect-brk')) {
if (run && run.includes('--inspect-brk')) {
run = options._[1]
}

Expand Down
Loading