Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix programmatic focus/blur events, typing into currently focused #2982

Merged
merged 45 commits into from
Jun 11, 2019

Conversation

kuceb
Copy link
Contributor

@kuceb kuceb commented Dec 22, 2018

fix #2176


tasks

  • intercept calls to .blur + test
  • add comments on tests referencing issues
  • add test for focusing on already active element
  • make document.hasFocus() always return true
  • follow all the rules on whether element should fire focus events (is focusable, not activeElement)
  • move test from focus_spec to type_spec
  • add more specific element tests to focus_blur_spec
  • add tests for selectionchange event to focus_blur_spec
  • add intercept for SVGElement focus/blur

review tasks

  • fix package.json dep version

@kuceb kuceb requested a review from brian-mann December 22, 2018 02:58
@kuceb kuceb force-pushed the click-command-focus branch from 887522b to c1b761e Compare December 22, 2018 03:00
@brian-mann
Copy link
Member

We need to work on this PR a bit and clean it up before merging. Also we need some issues that this PR fixes. Wasn't there one or more issues you went through on the existing cy.click() issues that this fixed?

@brian-mann
Copy link
Member

Also it appears this PR is fixing two things - 1 being forcing the focus/blur events, the other finding the focusable element in the situation such as [contenteditable]

We'll need to reference multiple issues here.

@kuceb kuceb changed the title fix programmatic blur events, typing into currently focused, contenteditables fix programmatic blur events, typing into currently focused Dec 27, 2018
@kuceb
Copy link
Contributor Author

kuceb commented Dec 27, 2018

updated the fixed issues, should probably add a test for call to .blur however

edit: still need to fix this for programmatic blur

@kuceb kuceb changed the title fix programmatic blur events, typing into currently focused fix programmatic focus/blur events, typing into currently focused Dec 27, 2018
@kuceb
Copy link
Contributor Author

kuceb commented Dec 27, 2018

Updating this now to intercept .blur calls

@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Feb 7, 2019
@PhilipGrey
Copy link

Looking forward to this.

@kuceb kuceb requested a review from jennifer-shehane May 24, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants