misc: allow HiDPI Screen running wayland to use cypress window/browser #30109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/support_hidpi_wayland
|
| Run status |
|
| Run duration | 48m 17s |
| Commit |
|
| Committer | AtofStryker |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
116
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
null%
|
|
|---|---|
|
Untested elements
|
0
|
|
Tested elements
|
0
|
Accessibility
null%
|
|
|---|---|
|
Failed rules
|
0 critical
0 serious
0 moderate
0 minor
|
|
Failed elements
|
0
|
ryanthemanuel
approved these changes
Aug 26, 2024
jennifer-shehane
approved these changes
Aug 26, 2024
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
A revisit of #29366. When merging in #29366, there were issues detecting the
--ozone-platform=autoin older versions of linux distributions, the--ozone-platform-hintargument is in place to not make this a critical error when testing the binaryFrom original PR #29366:
High demand of HiDPI Screen and multi monitor setups make people tend to use fractional scaling for each their own monitor differently. Problem happens when using chromium based app that can lead to blurriness of the UI. By providing simple flag to the electron arguments
--ozone-platform=autowhich literally can backwards compatible will help Wayland users to use chromium/electron without blurry texts, the flag also compatible with x11 window system if it's the only available option.Just small change to add the flag to the spawn.js file
Steps to test
It's already tested here
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?