dependency: upgrade to electron 29 #30224

ryanthemanuel · 2024-09-11T13:53:16Z

CHANGELOG - https://releases.electronjs.org/releases/stable?version=29

Additional details

Upgrade to Chromium 122
Upgrade to Node 20.9.0+
Upgrade to v8 12.0

Related Docker Images PR https://github.com/cypress-io/cypress-docker-images/pull/1052/files

Unfortunately there is a breaking change in Electron 28 that would affect our users. That breaking change has been fixed in Electron 29, but Electron 29 contains a bug in v8 that we've had to raise with Chromium here: issues.chromium.org/issues/345280736 We're awaiting to see what their response is as we need a resolution to continue our upgrade.

Steps to test

How has the user experience changed?

PR Tasks

Have tests been added/updated?
Has a PR for user-facing changes been opened in cypress-documentation?
Have API changes been updated in the type definitions?

…nto electron-28

…ooks running [run ci]

…tron-28

jennifer-shehane · 2024-09-11T15:59:15Z

npm/puppeteer/tsconfig.json

@@ -16,7 +16,7 @@
    "types": [
      "cypress",
      "./support",
-      "./node_modules/@types/node"
+      "node"


To address this error: https://app.circleci.com/pipelines/github/cypress-io/cypress/59971/workflows/b10cb9c6-89ad-4a6b-8ae8-9ff9d8d6121e/jobs/2495052

jennifer-shehane · 2024-09-11T15:59:56Z

packages/data-context/src/DataContext.ts

@@ -181,6 +181,7 @@ export class DataContext {
  @cached
  get cloud () {
    return new CloudDataSource({
+      // @ts-ignore


To address error below. Open to better ideas here. https://app.circleci.com/pipelines/github/cypress-io/cypress/59948/workflows/efa9b4b3-12ca-4f83-a8d7-d5c9186f28d4/jobs/2493976

jennifer-shehane · 2024-09-11T16:00:47Z

packages/driver/cypress/e2e/commands/net_stubbing.cy.ts

@@ -26,6 +26,7 @@ describe('network stubbing', { retries: 15 }, function () {

  beforeEach(function () {
    cy.spy(Cypress.utils, 'warning')
+    cy.visit('/fixtures/empty.html')


We'll want to remove this. This should have only been necessary in Electron 28 - that's the assumption anyway. See https://github.com/cypress-io/cypress/pull/28959/files#r1603224984

jennifer-shehane · 2024-09-11T16:01:38Z

packages/server/package.json

@@ -39,7 +39,7 @@
    "ansi_up": "5.0.0",
    "ast-types": "0.13.3",
    "base64url": "^3.0.1",
-    "better-sqlite3": "9.2.2",
+    "better-sqlite3": "10.0.0",


@ryanthemanuel Do you remember the context as to why this was necessary?

I do not unfortunately. We can try reverting?

@AtofStryker do you happen to remember either? I know you were working in here too at times.

I was just wondering - I don't think have confirmation that it's breaking anything - it was just a difference between 29 and 28

This is needed due to this failure when it is left on 9.2.2: https://cloud.nx.app/runs/n23a1Mbn3x

scripts/binary/trigger-publish-binary-pipeline.js

jennifer-shehane · 2024-09-11T16:05:13Z

tooling/v8-snapshot/src/generator/snapshot-generator.ts

@@ -462,7 +462,7 @@ export class SnapshotGenerator {

    // 2. Run the `mksnapshot` binary providing it the path to our snapshot
    //    script
-    const args = [this.snapshotScriptPath, '--output_dir', this.snapshotBinDir]
+    const args = [this.snapshotScriptPath, '--output_dir', this.snapshotBinDir, '--no-use-ic']


See https://issues.chromium.org/issues/345280736#comment12 for context - we should add this inline as a comment.

This is here: cypress-io/cypress-publish-binary#70

…nto electron-29

cypress · 2024-09-11T18:14:42Z

cypress Run #57052

Run Properties: Failed #57052 • f03ad631d8: try something else

Project	`cypress`
Branch Review	`electron-29`
Run status	`Failed #57052`
Run duration	`18m 24s`
Commit	`f03ad631d8: try something else`
Committer	`Ryan Manuel`
View all properties for this run ↗︎

Test results
Failures	`2`
Flaky	`2`
Pending	`26`
Skipped	`0`
Passing	`768`
View all changes introduced in this branch ↗︎

UI Coverage `67.9%`
Untested elements	`24`
Tested elements	`55`

Accessibility `96.4%`
Failed rules	`0 critical` `6 serious` `1 moderate` `0 minor`
Failed elements	`210`

Tests for review

cypress\e2e\config-files-error-handling.cy.ts • 1 failed test • launchpad-e2e

View Output

Test		Artifacts
Launchpad: Error System Tests > shows correct stack trace when config with ts-module error		`Test Replay` `Screenshots`

cypress\e2e\runner\retries.experimentalRetries.mochaEvents.cy.ts • 1 failed test • app-e2e

View Output

Test		Artifacts
... > does not try to serialize error with err.actual as DOM node		`Test Replay` `Screenshots`

cypress\e2e\specs.cy.ts • 1 flaky test • app-e2e

View Output

Test		Artifacts
... > scaffold starter spec > generates spec with file name that does not contain a known spec extension		`Test Replay` `Screenshots`

cypress\e2e\subscriptions\createCloudOrgModal-subscription.cy.ts • 1 flaky test • app-e2e

View Output

Test		Artifacts
CreateCloudOrgModalSubscription > Runs - Connect Org > opens create Org modal after clicking Connect Project button		`Test Replay` `Screenshots`

scripts/binary/trigger-publish-binary-pipeline.js

jennifer-shehane · 2024-09-12T18:59:10Z

packages/server/lib/gui/windows.ts

@@ -185,7 +185,7 @@ export function create (projectRoot, _options: WindowOptions, newBrowserWindow =
    })
  }

-  win.webContents.on('crashed', function (...args) {
+  win.webContents.on('render-process-gone', function (...args) {


Addresses this type failure: https://cloud.nx.app/runs/cibLuMvwic

This event was removed in 29: https://github.com/electron/electron/pull/40115/files#diff-18ed6a5b5a9084c976509502962b7f05989a8bd13a2ba3dc02868056938c03b6

…nto electron-29

jennifer-shehane · 2024-10-29T15:03:51Z

Superseded by this PR: #30394

jennifer-shehane and others added 30 commits February 16, 2024 10:52

bump Electron/node/node-abi + run extra workflows in CI

121aef3

empty commit

a74681e

bump docker images to node + chrome versions for Electron 28

6e73a3e

bump node types

05f873d

bump xcode to version with default Node v18.17.1

1cbd4ea

Merge branch 'develop' into electron-28

fe34d4d

Bump types/node

837a079

Merge branch 'electron-28' of https://github.com/cypress-io/cypress i…

23cbb71

…nto electron-28

update getFileName to follow types of string or undefined

652eeaa

ts-ignore fetch spread

0d3bae1

yarn lock update

8e66ac2

bump system test yarn lock

2ef87a0

yarn/types node bump

3b9c2d9

fix types definition for node types

de8ab30

Merge branch 'develop' into electron-28

306e5b6

Merge branch 'develop' into electron-28

5f40d20

Merge branch 'develop' into electron-28

1401928

Merge branch 'develop' of github.com:cypress-io/cypress into electron-28

1113a99

empty commit to run ci [run ci]

ef36f34

fix merge conflict because vscode is really slow to save files with h…

763367a

…ooks running [run ci]

empty commit to run ci [run ci]

1fbc23c

print original toString for fs temporarily to swap value [run ci]

2a6d6e2

fix typing issues

decdca0

update integrity check [run ci]

99d1620

fix stack integrity check

52addeb

use 18.20.2 docker image [run ci]

500225b

Update binary-integrity-check-source.js

de6a1fd

Update smoke.js

e858554

update trigger binary publish and bump cache [run ci]

9985f75

Merge branch 'electron-28' of github.com:cypress-io/cypress into elec…

67c4065

…tron-28

jennifer-shehane reviewed Sep 11, 2024

View reviewed changes

scripts/binary/trigger-publish-binary-pipeline.js Outdated Show resolved Hide resolved

jennifer-shehane reviewed Sep 11, 2024

View reviewed changes

jennifer-shehane added 3 commits September 11, 2024 12:10

Update scripts/binary/trigger-publish-binary-pipeline.js

01023e0

This is here: cypress-io/cypress-publish-binary#70

add code comment for why --no-use-ic flag is there

4255fb5

Merge branch 'electron-29' of https://github.com/cypress-io/cypress i…

9f31f09

…nto electron-29

jennifer-shehane mentioned this pull request Sep 11, 2024

fix(dep): Upgrade Electron 28 #28959

Closed

3 tasks

remove 'empty' visits to ensure 29 works without these changes.

ee67e7b

jennifer-shehane and others added 6 commits September 11, 2024 16:36

try to downgrade better-sqlite

2bce45f

better-sqlite3 10

44c070d

fix build

9fe813a

fix

ba370fc

ensure that the branch gets used in the publish step

a50043e

turn off auto-cancellation for these runs to see what's failing

01bdddc

ryanthemanuel commented Sep 12, 2024

View reviewed changes

scripts/binary/trigger-publish-binary-pipeline.js Outdated Show resolved Hide resolved

ryanthemanuel added 3 commits September 12, 2024 09:25

Update scripts/binary/trigger-publish-binary-pipeline.js

beea4b7

fix types error

cad44d8

remove gcc

2e8876e

jennifer-shehane changed the title ~~fix(dep): upgrade to electron 29~~ dependency: upgrade to electron 29 Sep 12, 2024

try something

0ae94b2

jennifer-shehane reviewed Sep 12, 2024

View reviewed changes

ryanthemanuel and others added 3 commits September 12, 2024 14:02

try something else

f03ad63

bump Node.js to 20

4f849dd

Merge branch 'electron-29' of https://github.com/cypress-io/cypress i…

610ea3b

…nto electron-29

jennifer-shehane closed this Oct 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dependency: upgrade to electron 29 #30224

dependency: upgrade to electron 29 #30224

ryanthemanuel commented Sep 11, 2024 •

edited by jennifer-shehane

Loading

jennifer-shehane Sep 11, 2024

jennifer-shehane Sep 11, 2024

jennifer-shehane Sep 11, 2024

jennifer-shehane Sep 11, 2024

ryanthemanuel Sep 11, 2024

ryanthemanuel Sep 11, 2024

jennifer-shehane Sep 11, 2024

jennifer-shehane Sep 12, 2024 •

edited

Loading

jennifer-shehane Sep 11, 2024

cypress bot commented Sep 11, 2024 •

edited

Loading

jennifer-shehane Sep 12, 2024 •

edited

Loading

jennifer-shehane commented Oct 29, 2024

dependency: upgrade to electron 29 #30224

dependency: upgrade to electron 29 #30224

Conversation

ryanthemanuel commented Sep 11, 2024 • edited by jennifer-shehane Loading

Additional details

Steps to test

How has the user experience changed?

PR Tasks

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jennifer-shehane Sep 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cypress bot commented Sep 11, 2024 • edited Loading

Tests for review

jennifer-shehane Sep 12, 2024 • edited Loading

Choose a reason for hiding this comment

jennifer-shehane commented Oct 29, 2024

ryanthemanuel commented Sep 11, 2024 •

edited by jennifer-shehane

Loading

jennifer-shehane Sep 12, 2024 •

edited

Loading

cypress bot commented Sep 11, 2024 •

edited

Loading

jennifer-shehane Sep 12, 2024 •

edited

Loading