chore: remove react dependency from the server as it looks unused #30515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
added
the
pkg/reporter
AtofStryker
changed the title
AtofStryker
changed the title
AtofStryker
force-pushed
the
chore/remove_react_server
branch
from
94e1072
to
8bdc016
Compare
ryanthemanuel
approved these changes
Nov 4, 2024
jennifer-shehane
requested changes
Nov 4, 2024
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/remove_react_server
|
| Run status |
|
| Run duration | 24m 01s |
| Commit |
|
| Committer | AtofStryker |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
7
|
Pending
|
1326
|
Skipped
|
0
|
Passing
|
29395
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.11%
|
|
|---|---|
|
Untested elements
|
189
|
|
Tested elements
|
166
|
Accessibility
92.55%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
903
|
@jennifer-shehane There are no lock file changes. Likely because the same version is already installed in the lock globally. I double checked to make sure |
jennifer-shehane
approved these changes
Nov 4, 2024
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Removes a stale
reactdependency from the server package as it isn't used. This should make #30510 easier to accomplishSteps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?