Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flakey tests #3227

Merged
merged 16 commits into from
Jan 29, 2019
Merged

fix flakey tests #3227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2f4169d
add tests, escapse strings for console
kuceb Jan 14, 2019
0daaaf4
add comment about tests in logger.js
kuceb Jan 14, 2019
09474d1
fix undefined prop bug
kuceb Jan 14, 2019
e54bb05
fix broken test
kuceb Jan 14, 2019
e9ee0e1
move diff to dependencies
kuceb Jan 16, 2019
db7df10
Merge branch 'develop' into issue-3129
kuceb Jan 16, 2019
64200c6
Merge remote-tracking branch 'origin/develop' into issue-3129
kuceb Jan 22, 2019
a3cccb8
fix escape function, add more tests, refacter showDiff
kuceb Jan 22, 2019
7cdf4f6
pin diff dependency
kuceb Jan 24, 2019
32c0d75
fix flakey timers_spec
kuceb Jan 25, 2019
c383155
fix flakey timers_spec
kuceb Jan 25, 2019
f98bad0
fix another flaky tests, seems .should doesn't retry when chained off…
kuceb Jan 25, 2019
80ce5f6
Merge remote-tracking branch 'origin/issue-3129' into flaky-timers_spec
kuceb Jan 25, 2019
74e13bc
timers_spec fix update, comment
kuceb Jan 25, 2019
e48d701
timers_spec fix update, comment
kuceb Jan 25, 2019
20b59c6
Revert "Merge remote-tracking branch 'origin/issue-3129' into flaky-t…
kuceb Jan 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions packages/driver/test/cypress/integration/commands/xhr_spec.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1915,13 +1915,16 @@ describe "src/cy/commands/xhr", ->
xhr.foo = "bar"
resolve(xhr)
xhr.send()
.should (xhr) ->
## ensure this is set to prevent accidental
## race conditions down the road if something
## goes wrong
expect(xhr.foo).to.eq("bar")
expect(xhr.aborted).not.to.be.true
expect(log.get("state")).to.eq("passed")
.then (xhr) ->
cy
.wrap(null)
.should ->
## ensure this is set to prevent accidental
## race conditions down the road if something
## goes wrong
expect(xhr.foo).to.eq("bar")
expect(xhr.aborted).not.to.be.true
expect(log.get("state")).to.eq("passed")

context "Cypress.on(window:unload)", ->
it "aborts all open XHR's", ->
Expand Down
9 changes: 7 additions & 2 deletions packages/driver/test/cypress/integration/cy/timers_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,12 +387,17 @@ describe('driver/src/cy/timers', () => {
.then((win) => {
const stub1 = cy.stub()

win.setTimeout(stub1, 200)
// we're setting setTimeout to 500ms because
// there were times where the driver's webserver
// was sending bytes after 200ms (TTFB) that caused
// this test to be flaky.
win.setTimeout(stub1, 500)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just thought of a better approach here...

Instead of hoping the webserver sends us back the response in 500ms, we could instead use cypress events to wait for the window:unload event, gauranteeing this has happened.

At that point we could then set the setTimeout and then assert its not called after waiting.


// force the window to sync reload
win.location.reload()

cy
.wait(400)
.wait(800)
.then(() => {
expect(stub1).not.to.be.called
})
Expand Down