Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize source maps for error improvements #4041

Conversation

chrisbreiding
Copy link
Contributor

Closes #3966

@jennifer-shehane
Copy link
Member

Hmmm, wonder if we should converge on a PR to work on together for this.

@chrisbreiding chrisbreiding changed the base branch from develop to jen/reporter-error-templates-fix May 1, 2019 17:50
@cypress
Copy link

cypress bot commented Aug 7, 2019



Test summary

3762 0 50 0


Run details

Project cypress
Status Passed
Commit ffee0bc
Started Jan 8, 2020 8:29 PM
Ended Jan 8, 2020 8:33 PM
Duration 04:43 💡
OS Linux Debian - 9.11
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@chrisbreiding chrisbreiding mentioned this pull request Dec 19, 2019
3 tasks
@jennifer-shehane
Copy link
Member

[desktop-gui:build  ] ERROR in ../ui-components/src/select/select.scss
[desktop-gui:build  ] Module build failed (from ../web-config/node_modules/mini-css-extract-plugin/dist/loader.js):
[desktop-gui:build  ] ModuleBuildError: Module build failed (from ../web-config/node_modules/sass-loader/lib/loader.js):
[desktop-gui:build  ] 
[desktop-gui:build  ]     @extend .#{$fa-css-prefix}-circle-o;
[desktop-gui:build  ]              ^
[desktop-gui:build  ]       Undefined variable: "$fa-css-prefix".
[desktop-gui:build  ]       in /root/cypress/packages/ui-components/src/select/select.scss (line 13, column 15)
[desktop-gui:build  ]     at /root/cypress/packages/desktop-gui/node_modules/webpack/lib/NormalModule.js:302:20
[desktop-gui:build  ]     at /root/cypress/packages/desktop-gui/node_modules/loader-runner/lib/LoaderRunner.js:367:11
[desktop-gui:build  ]     at /root/cypress/packages/desktop-gui/node_modules/loader-runner/lib/LoaderRunner.js:233:18
[desktop-gui:build  ]     at context.callback (/root/cypress/packages/desktop-gui/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
[desktop-gui:build  ]     at Object.callback (/root/cypress/packages/web-config/node_modules/sass-loader/lib/loader.js:52:13)
[desktop-gui:build  ]     at Object.done [as callback] (/root/cypress/packages/web-config/node_modules/neo-async/async.js:8067:18)
[desktop-gui:build  ]     at options.error (/root/cypress/packages/web-config/node_modules/node-sass/lib/index.js:294:32)

Comment on lines 35 to 37
<Panel header='Proxy Settings' key='proxy-settings' className='form-horizontal settings-proxy'>
<ProxySettings app={app} />
</Panel>
Copy link
Contributor

@flotwig flotwig Jan 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Proxy Settings" is technically a "Global Setting", at some point, we should move the preferred editor + proxy settings to their own "Global Settings" section that is distinct from project-level settings.

So we don't overly inflate the UI changes from this PR, maybe the "Proxy Settings" should just be moved into the new "Global Settings" section for now?

@chrisbreiding chrisbreiding changed the title WIP: Utilize source maps for error improvements Utilize source maps for error improvements Jan 8, 2020
@chrisbreiding chrisbreiding merged commit ffee0bc into jen/reporter-error-templates-fix Jan 8, 2020
@cypress-bot cypress-bot bot mentioned this pull request Jan 8, 2020
@chrisbreiding chrisbreiding deleted the issue-3966-source-for-command-failures branch April 5, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants