Add Google Cloud env vars to ci_providers check #4191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jennifer-shehane
commented
May 14, 2019
jennifer-shehane
commented
- close Support Google Cloud Build details in Cypress Dashboard #3582
bahmutov
reviewed
Jun 4, 2019
| @@ -468,7 +493,7 @@ const commitDefaults = function (existingInfo) { | |||
| // defaulting back to null if all fails | |||
| // NOTE: only properties defined in "existingInfo" will be returned | |||
| const combined = _.transform(existingInfo, (memo, value, key) => { | |||
| return memo[key] = _.defaultTo(value != null ? value : commitParamsObj[key], null) | |||
| return memo[key] = _.defaultTo(value || commitParamsObj[key], null) | |||
There was a problem hiding this comment.
hmm, changing the logic here, right? because now it treats empty strings and undefined values differently. But I don't see any changed unit tests
There was a problem hiding this comment.
This is a decaffeinate fix, just a shorter null check. It should be equivalent since the original was an existential coffeescript check, but also, they always say "may not be equivalent", so yah I will add a unit test.
bahmutov
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.