agent: Fix NO_PROXY not respected for HTTPS urls #4309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
flotwig
commented
May 24, 2019
flotwig
commented
- Fixes NO_PROXY ignored when baseUrl is set #4303
- NO_PROXY is now respected for HTTPS urls, as it should be
flotwig
changed the title
|
This will be great to have in, it's currently blocking us upgrading to 3.3.1 :) |
moraza
approved these changes
Jun 4, 2019
brian-mann
approved these changes
Jun 14, 2019
|
I have no idea what the hold up is, sorry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.