-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn when Cypress detects policies that may interfere with automating Chrome #4405
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The on link should be a direct link run through https://github.com/cypress-io/cypress-services/blob/develop/packages/on/data/links.yml#L60, not the link + hash
@jennifer-shehane I've updated it to https://on.cypress.io/bad-browser-policy , just not in the screenshots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Didn't manually test though.
Hi, great job! In my opinion, the balloon tip will be enough when you move the content from yellow warning message to the balloon tip. If you insist on leaving the yellow warning message, please make it more condensed, as the version presented on screenshots contains unnecessary newlines between sentences. Keep working on Cypress! It's awesome, even with its limitations. |
packages/desktop-gui/cypress/integration/project_nav_spec.coffee
Outdated
Show resolved
Hide resolved
packages/server/package.json
Outdated
"winston": "1.1.2" | ||
}, | ||
"optionalDependencies": { | ||
"@cypress/registry-js": "1.3.3-patch1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I was wondering why this PR didn't seem to be having any effect!
Fixes #4391
Warning in run mode (only if they're using a Chrome-family browser):
Tooltip warning