Better support for circular references in certain objects, fix patching of socket package #4469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e0d7672.
flotwig
changed the title
flotwig
changed the title
flotwig
changed the title
brian-mann
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
socket.io-circular-parserwhere packets of typeBINARY_EVENTorBINARY_ACKwere recursed into infinitely (fixes Test runner hangs with RangeError: Maximum call stack size exceeded #4346 part II)what-is-circularwhere incorrect path would be returned for non-circular and circular arraysnpxto launchpatch-packagesince devDeps don't exist when we build on appveyor. Includespatcheswith@packages/socketso that they can be used.