Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow platform specific environment variables #5037

Closed
wants to merge 2 commits into from
Closed

Allow platform specific environment variables #5037

wants to merge 2 commits into from

Conversation

tomasbjerre
Copy link
Contributor

@tomasbjerre tomasbjerre commented Aug 24, 2019

The .npmrc can have:

CYPRESS_INSTALL_BINARY___linux = https://this.is/the/linux/binary.zip
CYPRESS_INSTALL_BINARY___win32 = https://this.is/the/win32/binary.zip

Where the suffix is taken from platform names in Nodejs.

So that on Windows the effective value of CYPRESS_INSTALL_BINARY would be https://this.is/the/win32/binary.zip.

Pre-merge Tasks

@CLAassistant
Copy link

CLAassistant commented Aug 24, 2019

CLA assistant check
All committers have signed the CLA.

@tomasbjerre tomasbjerre changed the title Allow platform specific environment variables #5036 Allow platform specific environment variables Aug 24, 2019
The `.npmrc` can have:
```
CYPRESS_INSTALL_BINARY___linux = https://this.is/the/linux/binary.zip
CYPRESS_INSTALL_BINARY___win32 = https://this.is/the/win32/binary.zip
```

Where the suffix is taken from platform [names in Nodejs](https://nodejs.org/api/process.html#process_process_platform).

So that on Windows the effective value of `CYPRESS_INSTALL_BINARY` would be `https://this.is/the/win32/binary.zip`.
@bahmutov
Copy link
Contributor

@tomasbjerre we have discussed this pull requests and have decided against it. It seems reading environment variables based on the OS is something external to the tool. For example, you could use something like https://github.com/bahmutov/as-a and its modification to run Cypress with the desired set of environment variables depending on the platform.

@bahmutov bahmutov closed this Sep 10, 2019
@tomasbjerre
Copy link
Contributor Author

If anyone else looking for this, see comment here: #5141 (comment)

@jennifer-shehane jennifer-shehane added the stage: wontfix Cypress does not regard this as an issue or will not implement this feature label May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage: wontfix Cypress does not regard this as an issue or will not implement this feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Platform specific environment variables
4 participants