Refactor proxy into own package, implement middleware pattern #5136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
flotwig
force-pushed
the
refactor-proxy
branch
5 times, most recently
from
177c15a to
a63182e
Compare
17 tasks
flotwig
force-pushed
the
refactor-proxy
branch
from
1bebe5d to
c151b0e
Compare
don't need these mocha opts anymore fix test no more zunder READMEs fix test
flotwig
force-pushed
the
refactor-proxy
branch
from
c151b0e to
d921ae7
Compare
2 tasks
flotwig
changed the title
jennifer-shehane
previously requested changes
Oct 10, 2019
brian-mann
previously requested changes
Oct 13, 2019
|
@brian-mann All decaffing was done in a separate PR: #5156 However, this PR moves to new packages + edits some files, so not sure if that will break Git history or what. |
flotwig
dismissed stale reviews from jennifer-shehane and brian-mann
responded
flotwig
force-pushed
the
refactor-proxy
branch
from
6ed7057 to
fb50e8d
Compare
flotwig
force-pushed
the
refactor-proxy
branch
from
9b6c5e2 to
27edf34
Compare
|
@brian-mann @jennifer-shehane Is this good to merge in? Just brought it back up to date with I believe all the feedback that was left previously has been addressed. Since this forms the basis for #687 I'd like to get it merged in |
jennifer-shehane
approved these changes
Nov 27, 2019
avallete
pushed a commit
to avallete/cypress
that referenced
this pull request
Nov 28, 2019
…s-io#5136) * renames * Refactor proxy into own package, implement middleware pattern don't need these mocha opts anymore fix test no more zunder READMEs fix test * pass request by reference * fix cors path * Move replace_stream to proxy, concat-stream util in network * Pin dependency versions * Revert addDefaultPort behavior * Add READMEs for proxy, network * Update README.md * eslint --fix * set to null not undefined * use delete and bump node types * import cors from package now * parse-domain@2.3.4 * proxy package needs common-tags * move pumpify dep * load through where it's needed, remove unused passthru_stream * remove unneeded getbuffer call Co-authored-by: Gleb Bahmutov <gleb.bahmutov@gmail.com>
santoshyadavdev
pushed a commit
to santoshyadavdev/cypress
that referenced
this pull request
Dec 5, 2019
…s-io#5136) * renames * Refactor proxy into own package, implement middleware pattern don't need these mocha opts anymore fix test no more zunder READMEs fix test * pass request by reference * fix cors path * Move replace_stream to proxy, concat-stream util in network * Pin dependency versions * Revert addDefaultPort behavior * Add READMEs for proxy, network * Update README.md * eslint --fix * set to null not undefined * use delete and bump node types * import cors from package now * parse-domain@2.3.4 * proxy package needs common-tags * move pumpify dep * load through where it's needed, remove unused passthru_stream * remove unneeded getbuffer call Co-authored-by: Gleb Bahmutov <gleb.bahmutov@gmail.com>
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proxy.coffeeand other related files from theserverinto a newproxypackage.proxy.coffeehas been split up into Request, Response, and Error middleware stacks, which are now easier to unit test.request.coffeehas been converted to Typescript and moved to thenetworkpackage along with associated tests.Pending Electron v5.0.10 #4720 -request.coffeewas changed a lot and it would be wasted effort to refactor it fromdevelopPre-merge Tasks
network,proxy