Control Chrome cookies through CDP

[flotwig]

• Closes cy.setCookie is broken with chrome 77 #5142
• Closes Use Chrome DevTools Protocol to set cookies in Chrome #5206

User facing changelog

• Improved the way that cookies are handled for Chrome-family browsers. Fixes setting a cookie with a domain beginning with a leading dot in Chrome 77. Closes cy.setCookie is broken with chrome 77 #5142, Use Chrome DevTools Protocol to set cookies in Chrome #5206.
• Added RFC 6265 compliant validation of cookie names and values in cy.setCookie. An error will be thrown if an invalid name or value is supplied to cy.setCookie.

Additional details

• Waiting on Connect to Chrome Remote Interface when launching Chrome and record video #4628
• Add tests that errors from automation still reach driver:
  • in chrome (develop), you can do cy.setCookie('foo', ' bar') and it fails saying failed to set cookie, and cookie not set
  • in electron, you do not get error, but cookie is not set
  • cookie should not be set and error should be thrown
• Added validation for names+values supplied to cy.setCookie.
  • Invalid cookies would still error once they reach the automation, but this allows us to give the user a higher-fidelity error than just "idk, Chrome didn't like ur cookie ¯\_(ツ)_/¯ "
  • waiting on Add parseCookieName, parseCookieValue methods charmander/strict-cookie-parser#1
• Moved the CDP implementation for Electron to new cdp_automation file
• Hooked Electron + Chrome's CRI from Connect to Chrome Remote Interface when launching Chrome and record video #4628 up to cdp_automation
• Changed Chrome and Electron's automation to use Page.captureScreenshot instead of the extension or Electron APIs for take:screenshot
• Left in the extension code, since it might be used for Add Firefox support #1359 (WebExtension support should be the same across browsers)
  • I think that now, all that the extension does is add a change listener for cookies, which is not possible in DevTools:

    cypress/packages/extension/app/background.coffee

    Lines 19 to 21 in 1afb6b6

    	chrome.cookies.onChanged.addListener (info) ->
    	if info.cause isnt "overwrite"
    	ws.emit("automation:push:request", "change:cookie", info)

PR Tasks

• Have tests been added/updated?

[goktugy]

I ma afraid #5142 is still happening. If I don't use "domain" then set cookie works but it fails otherwise. When setting the cookie I can't set the domain information. Can someone please kindly look into this issue?

[flotwig]

@goktugy Please open a new issue and supply all the requested information, we can't really do anything with comments left on closed issues.