-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.5.0 - fix clicking into iframe after interaction with AUT #5520
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed this fixes the issue of trying to click or type into an input within an iframe so that it no longer throws.
packages/driver/test/cypress/integration/commands/actions/type_spec.js
Outdated
Show resolved
Hide resolved
…into fix-type-uncaught-errors-3.5.0
.ownerDocument
when deciding whether to send mouse leave events to an elementCloses 3.5.0 - CypressError: Timed out retrying: Cannot read property 'defaultView' of null #5449
includes link to issue
move test into click_spec
User facing changelog
bug fix: fixed issue preventing users from using
.click
or.type
inside an iframe element.Additional details
How has the user experience changed?
When trying to
click
ortype
into aniframe
, the test will no longer fail withCypressError: cannot read propery defaultView of null
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?