fix pollution of :contains pseudo selector

[kuceb]

• fixes issue introduced by cy.contains() improvements: normalizing whitespaces, case-sensi… #5653

• TODO: this should be revisited eventually. Right now there are 2 different contains variants - cy.contains(…) (which accepts options), and expect(…).contain(…) / cy.get(…).should('contain', …) (which do not accept options)

• Closes cy.contains() falsely failing when using negative assertion 'not.contain' #6384

User facing changelog

fix regression introduced in 4.0 causing incorrect assertion when chaining .should('contain', …) on a cy.contains(…)

Additional details

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• Has the original issue been tagged with a release in ZenHub?

[cypress-bot]

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

• Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
• Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

• The feature/bugfix is self-documenting from within the product.
• The change provides the end user with a way to fix their problem (no dead ends).

Functionality

• The code works and performs its intended function with the correct logic.
• Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
• The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

• The code is readable (too many nested 'if's are a bad sign).
• Names used for variables, methods, etc, clearly describe their function.
• The code is easy to understood and there are relevant comments explaining.
• New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
• There are comments containing link(s) to the addressed issue (in tests and code).

Quality

• The change does not reimplement code.
• There's not a module from the ecosystem that should be used instead.
• There is no redundant or duplicate code.
• There are no irrelevant comments left in the code.
• Tests are testing the code’s intended functionality in the best way possible.

Internal

• The original issue has been tagged with a release in ZenHub.

[cypress]

---

Test summary

6865 • 0 • 97 • 0

---

Run details

Project	cypress
Status	Passed
Commit	f87984e
Started	Feb 14, 2020 8:38 PM
Ended	Feb 14, 2020 8:44 PM
Duration	06:32 💡
OS	Linux Debian - 9.11
Browser	Multiple

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[jennifer-shehane]

I manually verified that this fixes the original issue.

[brian-mann]

this PR is a little weird in that its mutating jquery's $.expr[':'] which will persist after the query has run...

it may be worth deleting the :cy-contains selector.

there is a method in jquery that "compiles" selectors as well, which we may want to do

Also your comment here:

TODO: this should be revisited eventually. Right now there are 3 different contains variants - cy.contains(...) (which takes options), expect(...).contain(...), and cy.get(...).should('contain', '...')

There are not 3 variants, there are only 2 right? .should('contain') is the same thing as expect(...).to.contain(...) yeah?