Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract out ui-components dropdown #6452

Merged
merged 6 commits into from
Feb 14, 2020
Merged

Conversation

brian-mann
Copy link
Member

@brian-mann brian-mann commented Feb 13, 2020

User facing changelog

Not user-facing

Additional details

This was extracted from #3930 to make that PR simpler. It pulls out the dropdown used in the desktop-gui and runner into a single re-usable component.

How has the user experience changed?

N/A

PR Tasks

  • Have tests been added/updated?
  • N/A Has the original issue been tagged with a release in ZenHub?
  • N/A Has a PR for user-facing changes been opened in cypress-documentation?
  • N/A Have API changes been updated in the type definitions?
  • N/A Have new configuration options been added to the cypress.schema.json?

Co-authored-by: Chris Breiding <chrisbreiding@gmail.com>
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 13, 2020

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@cypress
Copy link

cypress bot commented Feb 13, 2020



Test summary

6872 0 97 0


Run details

Project cypress
Status Passed
Commit dc1c591
Started Feb 14, 2020 2:13 PM
Ended Feb 14, 2020 2:19 PM
Duration 05:53 💡
OS Linux Debian - 9.11
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@brian-mann brian-mann changed the title [WIP] extract out ui-components dropdown extract out ui-components dropdown Feb 13, 2020
@chrisbreiding chrisbreiding merged commit 1069310 into develop Feb 14, 2020
@chrisbreiding chrisbreiding deleted the ui-components-dropdown branch February 14, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants