-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decaff driver part 2 #7162
Decaff driver part 2 #7162
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
Hey @sainthkh, I sent you an email today at sainthkh@gmail.com - is this the right email to send you a message? |
1a84d25
to
59ca1b9
Compare
Flaky failures.
|
options = (o = _.extend({}, options, args[0])) | ||
} else if (args.length === 0) { | ||
$errUtils.throwErrByPath('route.invalid_arguments') | ||
} else if (args.length === 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these following else if
with arge.length === n
exclude each other, so can just be standard if
statements. Always prefer standalone if
statements over long else if
chains. Can you update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should not be updated. Because when executing if-else
statement, when the first condition met, other conditions below are ignored.
In this case, if we remove all else
s, when the first argument is object type, the first condition and args.length === 1
are met. So, it breaks the program. Actually, it did so.
59ca1b9
to
d08337c
Compare
d08337c
to
145bea0
Compare
Flaky failure. |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Part of #2690
NEVER SQUASH THIS PR.