-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass version number to plugin. #7925
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for taking the time to open a PR!
|
sainthkh
force-pushed
the
issue-6352
branch
3 times, most recently
from
July 13, 2020 06:39
a4fa8b2
to
7f6b9ee
Compare
Flaky failures + Github server errors. |
sainthkh
force-pushed
the
issue-6352
branch
2 times, most recently
from
July 16, 2020 00:20
772df22
to
478f186
Compare
chrisbreiding
requested changes
Jul 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just the one change to make. The documentation can go here, in the note concerning the projectRoot and configFile properties.
Flaky test. |
chrisbreiding
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Pass version number to plugin for better handling breaking changes.
Additional details
How has the user experience changed?
N/A
PR Tasks
cypress-documentation
? The explanation about the version number property in config of the plugin cypress-documentation#3009type definitions
?cypress.schema.json
?