Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass version number to plugin. #7925

Merged
merged 4 commits into from
Jul 22, 2020

Conversation

sainthkh
Copy link
Contributor

@sainthkh sainthkh commented Jul 9, 2020

User facing changelog

Pass version number to plugin for better handling breaking changes.

Additional details

  • Why was this change necessary? Help users hand breaking changes.
  • What is affected by this change? N/A
  • Any implementation details to explain? N/A

How has the user experience changed?

N/A

PR Tasks

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 9, 2020

Thanks for taking the time to open a PR!

@sainthkh sainthkh force-pushed the issue-6352 branch 3 times, most recently from a4fa8b2 to 7f6b9ee Compare July 13, 2020 06:39
@sainthkh sainthkh marked this pull request as ready for review July 13, 2020 06:53
@sainthkh
Copy link
Contributor Author

sainthkh commented Jul 13, 2020

Flaky failures + Github server errors.

Copy link
Contributor

@chrisbreiding chrisbreiding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just the one change to make. The documentation can go here, in the note concerning the projectRoot and configFile properties.

packages/server/lib/plugins/child/run_plugins.js Outdated Show resolved Hide resolved
@sainthkh
Copy link
Contributor Author

Flaky test.

@sainthkh sainthkh requested a review from chrisbreiding July 21, 2020 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugins need to know the Cypress version running
3 participants