-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change lodash to caret semver range #8032
Conversation
To allow for ranges on volatile packages like lodash. Changes default specified in #2992 Renovate Docs: https://docs.renovatebot.com/configuration-options/#rangestrategy
This allows consumers to update `lodash` versions to address security issues without using special tools like Yarn Resolutions or npm overrides. Since lodash is a volatile package in regards to security updates, this seems like a good tradeoff to make.
Thanks for taking the time to open a PR!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted before, will have to bring this up to discuss with the team, if we want to change this strategy. #7921 (comment)
Ok, I suspected this may be something going in the "strategy discussion" direction. To provide an example for the discussion, here |
cypress pins lodash version: cypress-io/cypress#8032
@karlhorky Our team has decided that this is a change we would like to make. The body of work is a bit larger than is covered here in this PR, since there are some stickier things with version control going on when we build the binary. So, I've created a new issue to outline the work necessary. #8046 We'll have a new PR to address the full changes, so I'll be closing this one. Thanks for bringing this up! I think it helped get the ball rolling on things. |
Thanks for the update @jennifer-shehane, sounds good. Glad to help :) |
User facing changelog
Change
lodash
to use caret semver range due to frequent security issues.Additional details
This allows consumers to update
lodash
versions to address security issues without using special tools like Yarn Resolutions or npm overrides. Sincelodash
is a volatile package in regards to security updates, this seems like a good tradeoff to make.This changes the Renovate configuration originally specified by @bahmutov in #2992
Renovate
rangeStrategy
Docs:https://docs.renovatebot.com/configuration-options/#rangestrategy
How has the user experience changed?
lodash
without updatingcypress
PR Tasks
None applicable.
┆Issue is synchronized with this Jira Features by Unito