Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reporter): minor UI fixes and improvements #8153

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

panzarino
Copy link
Contributor

@panzarino panzarino commented Aug 1, 2020

User facing changelog

Minor fixes and improvements to the reporter UI

How has the user experience changed?

Before:

ezgif-4-2f9979110c7e

After:

ezgif-4-2033612294e3

Before:

ezgif-4-cf26895c75e9

After:

ezgif-4-9edee687640a

Before:

ezgif-4-075c2323b3ce

After:

ezgif-4-5ee50b9eb12f

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 1, 2020

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Aug 1, 2020



Test summary

7923 0 130 2


Run details

Project cypress
Status Passed
Commit 87cb89a
Started Aug 1, 2020 5:47 AM
Ended Aug 1, 2020 5:57 AM
Duration 09:46 💡
OS Linux Debian - 10.1
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panzarino Seems like if the test is skipped (there's nothing to show inside of it) that hovering over it shouldn't show cursor: pointer/hover styles cause it seems like you can click on it but it's just not opening. But...some of the pending states (like the pending suites) can expand, so...it'd have to be really targeted styling.

Anyway, this is all improvements overall, so looks good. Going to merge.

@jennifer-shehane jennifer-shehane merged commit 19393e0 into develop Aug 3, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 3, 2020

Released in 4.12.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.12.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 3, 2020
@emilyrohrbough emilyrohrbough deleted the misc-reporter-ui-improvements branch August 1, 2024 13:49
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants