fix: Capture env vars from AWS Code Build #8159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
jennifer-shehane
changed the title
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
bahmutov
reviewed
Aug 3, 2020
| @@ -82,6 +88,7 @@ const isWercker = () => { | |||
| const CI_PROVIDERS = { | |||
| 'appveyor': 'APPVEYOR', | |||
| 'azure': isAzureCi, | |||
| 'awsCodeBuild': isAWSCodeBuild, | |||
There was a problem hiding this comment.
Suggested change
| 'awsCodeBuild': isAWSCodeBuild, | |
| 'awsCodeBuild': 'CODEBUILD_BUILD_ID', |
we can simply check for this environment variable, why is isAWSCodeBuild necessary?
There was a problem hiding this comment.
Just figure it covers more env vars if they ever change the CODEBUILD_BUILD_ID var
bahmutov
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User Changelog
Additional Details
AWS CodeBuild env vars: https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-env-vars.html
PR Tasks
cypress-documentation? Add AWS build id to parallel docs cypress-documentation#3046