-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency express to version 4.17.1 🌟 #8179
Conversation
See the guidelines for reviewing dependency updates for info on how to review dependency update PRs. |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it looks like express
updated one of their deps, finalhandler
, which has changed how they set content-security-policy
headers by default: pillarjs/finalhandler#26
This is causing this test to fail. I'm not sure if this will affect any behavior.
Cypress does its own stuff to the CSP header anyways (see #7936) so this change will be overridden by Cypress. We're seeing the snapshot change because the e2e scaffolding code uses |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
This PR contains the following updates:
4.16.4
->4.17.1
4.16.4
->4.17.1
Release Notes
expressjs/express
v4.17.1
Compare Source
===================
null
/undefined
tores.status
"v4.17.0
Compare Source
===================
express.raw
to parse bodies intoBuffer
express.text
to parse bodies into stringres.sendFile
null
/undefined
tores.status
X-Forwarded-Host
pb
) supportSameSite=None
supportContent-Security-Policy
headerpath.normalize
call103 Early Hints
throw
on invalid typeRenovate configuration
📅 Schedule: "before 3am on the first day of the month" in timezone America/New_York.
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by WhiteSource Renovate. View repository job log here.