fix: retries validation

[JessicaSachs]

• Validation of retries config was being ignored completely due to isNumberOrNull returning an error message string and being checked for falsiness.
• Previously both runMode and openMode were required when using the object signature. This fixes that.
• Previously we weren't guarding against negative numbers

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• Has the original issue been tagged with a release in ZenHub?
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?
• Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[cypress]

---

Test summary

8026 • 0 • 108 • 3

---

Run details

Project	cypress
Status	Passed
Commit	ab943aa
Started	Aug 13, 2020 1:28 AM
Ended	Aug 13, 2020 1:34 AM
Duration	05:57 💡
OS	Linux Debian - 10.2
Browser	Multiple

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[bahmutov]

retries: π

…

Sent from my iPhone

On Aug 12, 2020, at 21:12, Chris Breiding ***@***.***> wrote:  @chrisbreiding commented on this pull request. In packages/server/lib/util/validation.js: > @@ -104,18 +104,19 @@ const isValidBrowserList = (key, browsers) => { } const isValidRetriesConfig = (key, value) => { - const isNullOrNumber = isOneOf([_.isNumber, _.isNull]) - - if ( - isNullOrNumber(value) - || (_.isEqual(_.keys(value), ['runMode', 'openMode'])) - && isNullOrNumber(value.runMode) - && isNullOrNumber(value.openMode) - ) { + const optionalKeys = ['runMode', 'openMode'] + const isValidRetryValue = (val) => _.isNull(val) || (_.isNumber(val) && val >= 0) Should we go ahead and validate that it's an integer? Make sure some joker doesn't try retries: 2.3? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[chrisbreiding]

retries: π

End up in a retry loop.

[chrisbreiding]

Very nice!