Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NO_PROXY env var no longer be respected over npm_config_noproxy env var #8295

Merged
merged 3 commits into from
Aug 24, 2020

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Aug 17, 2020

User Facing Changelog

  • We fixed a regression in 4.11.0 where the NO_PROXY environment variable would no longer be respected over npm_config_noproxy environment variables. This could have potentially caused issue for proxied requests.

Additional Details

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 17, 2020

Thanks for taking the time to open a PR!

@jennifer-shehane jennifer-shehane changed the title Roll back proxy-from-env to 1.0.0 fix: NO_PROXY env var no longer be respected over npm_config_noproxy env var Aug 17, 2020
@jennifer-shehane
Copy link
Member Author

@flotwig Do you have some tests that would be good here? Feel free to take over the PR if so.

@cypress
Copy link

cypress bot commented Aug 17, 2020



Test summary

8118 0 108 3


Run details

Project cypress
Status Passed
Commit 501e052
Started Aug 24, 2020 6:49 PM
Ended Aug 24, 2020 6:55 PM
Duration 05:54 💡
OS Linux Debian - 10.2
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig
Copy link
Contributor

flotwig commented Aug 24, 2020

Added some tests which will catch this regression if it crops up again. Still using 1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If NPM config's noproxy is set, NO_PROXY rules will apply incorrectly
2 participants