-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix mjs file support #8395
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue has some links in the stack trace to .mjs file, wonder if it's related, but they didn't really give a repro #8373
I manually verified that this fixes the original issue. Tests look good. 👍
I know this is not the right place to ask, but is there any branch where upgrading to webpack 5 is being tested? Webpack has progressed to I tried pulling and upgrading |
User facing changelog
Additional Details
The true fix for this is in @cypress/webpack-batteries-included-preprocessor. This bumps its version and adds a test for .mjs files.
Also did some minor refactoring of the plugins e2e spec.
PR Tasks