Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix mjs file support #8395

Merged
merged 5 commits into from
Aug 25, 2020
Merged

fix: Fix mjs file support #8395

merged 5 commits into from
Aug 25, 2020

Conversation

chrisbreiding
Copy link
Contributor

@chrisbreiding chrisbreiding commented Aug 24, 2020

User facing changelog

  • Fixed an issue where .mjs files would error

Additional Details

The true fix for this is in @cypress/webpack-batteries-included-preprocessor. This bumps its version and adds a test for .mjs files.

Also did some minor refactoring of the plugins e2e spec.

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 24, 2020

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Aug 24, 2020



Test summary

8137 0 108 3


Run details

Project cypress
Status Passed
Commit ec76ab2
Started Aug 25, 2020 1:27 PM
Ended Aug 25, 2020 1:34 PM
Duration 06:32 💡
OS Linux Debian - 10.2
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue has some links in the stack trace to .mjs file, wonder if it's related, but they didn't really give a repro #8373

I manually verified that this fixes the original issue. Tests look good. 👍

@mwmcode
Copy link

mwmcode commented Oct 6, 2020

I know this is not the right place to ask, but is there any branch where upgrading to webpack 5 is being tested?

Webpack has progressed to ^5.0.0-rc.3 and webpack-preprocessor seems incompatible with it (some vague error about Automatic publicPath is not supported in this browser)

I tried pulling and upgrading webpack-preprocessor locally, but to no avail :(

@chrisbreiding chrisbreiding deleted the issue-8361-fix-mjs-support branch April 5, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants