Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(video): use wallclock timestamps and VFR with FF video recording #8851

Closed
wants to merge 3 commits into from

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Oct 14, 2020

User facing changelog

  • Fixed an issue where videos recorded in Firefox would play at the wrong speed or with inconsistent speed.

Additional details

  • previously using inputFPS, which resulted in extremely inconsistent video speeds when recording firefox
  • now using wallclock time to determine frame timestamps - still have the issue with missing intermediate frames, but at least the frame timestamps are more correct
  • also updated 6_video_compression_Spec to do a cy.visit in the middle, to ensure that we are not running into the issue where frames get overwritten when TS resets to 0

How has the user experience changed?

  • before, 6_video_compression spec recorded a ~3 second video of a 23 second test
  • now, 6_video compression spec records a ~23 second video of a 23 second test

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 14, 2020

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Oct 14, 2020



Test summary

8628 0 124 3Flakiness 1


Run details

Project cypress
Status Passed
Commit 24369fa
Started Oct 21, 2020 2:56 PM
Ended Oct 21, 2020 3:08 PM
Duration 12:20 💡
OS Linux Debian - 10.2
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig marked this pull request as ready for review October 14, 2020 20:37
@flotwig flotwig requested a review from kuceb October 14, 2020 20:37
Copy link
Contributor

@kuceb kuceb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately this still doesn't seem to fix the overwriting frames on visiting another domain:
before (6_visit_spec > e2e visit > passes)
wo

after
w

video is the correct length but it's just one frozen frame for the first half of the video

@flotwig
Copy link
Contributor Author

flotwig commented Oct 21, 2020

@flotwig flotwig requested a review from kuceb October 21, 2020 15:43
@flotwig flotwig marked this pull request as draft October 22, 2020 20:17
@flotwig flotwig closed this Feb 9, 2021
@flotwig flotwig deleted the issue-6337 branch January 24, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recorded videos from Firefox play at the wrong speed
2 participants