Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make lint script Windows compatible #160

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

MikeMcC399
Copy link
Collaborator

Issue

The script lint fails to run on Microsoft Windows operating systems. The error is:

$ npm run lint

> eslint-plugin-cypress@0.0.0-development lint
> eslint '*.js' '**/**/*.js'


Oops! Something went wrong! :(

ESLint: 5.16.0.
No files matching the pattern "'*.js'" were found.
Please check for typing mistakes in the pattern.

Change

The single-quotes in the script definition lint are changed to double-quotes and escaped for cross-compatibility with Windows.

Verification

On Ubuntu 22.04.4 LTS and on Windows 11 with Node.js 16.15.0 execute

npm ci
npm run lint

The output from the lint script should be as follows with no errors reported:

$ npm run lint

> eslint-plugin-cypress@0.0.0-development lint
> eslint "*.js" "**/**/*.js"

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 marked this pull request as ready for review April 12, 2024 07:58
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will be helpful to get other things working.

@jennifer-shehane jennifer-shehane merged commit 1c79609 into cypress-io:master Apr 12, 2024
7 checks passed
@MikeMcC399 MikeMcC399 deleted the lint-script-windows branch April 12, 2024 16:19
@cypress-app-bot
Copy link

🎉 This PR is included in version 2.15.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants