Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessionId support #439

Closed
flotwig opened this issue Dec 29, 2020 · 1 comment
Closed

sessionId support #439

flotwig opened this issue Dec 29, 2020 · 1 comment

Comments

@flotwig
Copy link

flotwig commented Dec 29, 2020

AFAIK currently, there's no way to set a sessionId for a single message like:

{
	id: ...,
	method: '...',
	params: { ... },
	sessionId: '...'
}

Chrome is planning to start requiring a sessionId to target a page at some point in the future: https://bugs.chromium.org/p/chromium/issues/detail?id=991325

Additionally, setting a sessionId is important if you connect to the global websocket instead of a target-specific websocket.

So this is probably something that should be added.

A sendRaw function that allows manually setting the entire message object would be fine for my use case too and wouldn't require too much refactoring.

@Niek
Copy link

Niek commented Mar 8, 2021

I switched to the chrome-debugging-client package since that properly supports sessionIDs.

cyrus-and added a commit that referenced this issue Mar 13, 2021
This closes #439 (feature request) and closes #441 as it provides a
more convenient implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants