Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add season translation #52

Merged
merged 4 commits into from
Jan 4, 2024
Merged

feat: add season translation #52

merged 4 commits into from
Jan 4, 2024

Conversation

just-tktok
Copy link

@just-tktok just-tktok commented Jan 3, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

tv_seasons.go Outdated
c.apiKey,
options,
)
tvSeasonVideos := TVSeasonTranslations{}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this variable name "tvSeasonVideos" to "tvTranslations"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@cyruzin
Copy link
Owner

cyruzin commented Jan 3, 2024

@just-tktok I left a comment and could you create the test too?

@just-tktok
Copy link
Author

@cyruzin i fix it

@cyruzin
Copy link
Owner

cyruzin commented Jan 4, 2024

@cyruzin i fix it

Hi, the test is failing:

./tv_seasons.go:357: Sprintf format %s reads arg #7, but call has 6 args

@just-tktok
Copy link
Author

@cyruzin i fix it

Hi, the test is failing:

./tv_seasons.go:357: Sprintf format %s reads arg #7, but call has 6 args

fix it

@cyruzin cyruzin merged commit 1ffc8ed into cyruzin:master Jan 4, 2024
2 of 3 checks passed
@cyruzin
Copy link
Owner

cyruzin commented Jan 4, 2024

@cyruzin i fix it

Hi, the test is failing:
./tv_seasons.go:357: Sprintf format %s reads arg #7, but call has 6 args

fix it

thanks

@cyruzin cyruzin added the enhancement New feature or request label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants